Page MenuHomePhabricator

CVS 1.5 crashes when $wgMaxCredits=-1
Closed, ResolvedPublic

Description

If you set $wgMaxCredits=-1; (in DefaultSettings.php), the wiki crashes

Database error
From Phase3
A database query syntax error has occurred. This may indicate a bug in the
software. The last attempted database query was:

SELECT rev_user, rev_user_text, user_real_name, MAX(rev_timestamp) as

timestamp FROM revision LEFT JOIN user ON rev_user = user_id WHERE rev_page =
AND old_user != 0 GROUP BY rev_user, rev_user_text, user_real_name ORDER BY
timestamp DESC

from within function "Article::getContributors". MySQL returned error "1064: You
have an error in your SQL syntax. Check the manual that corresponds to your
MySQL server version for the right syntax to use near 'AND old_user != 0 GROUP
BY rev_user, rev_user_text, user_rea".

See provisionally http://bugzilla.wikipedia.org/show_bug.cgi?id=508


Version: 1.5.x
Severity: normal

Details

Reference
bz1264
TitleReferenceAuthorSource BranchDest Branch
Add repos/search-platform/flink-rdf-streaming-updaterrepos/releng/gitlab-trusted-runner!15dcaussetrust-search-platform-flink-rdf-streaming-updatermain
Initial commitrepos/search-platform/flink-rdf-streaming-updater!1dcausseinitial-commitmain
Have Wikicode store a title instead of trying to parse itrepos/mwbot-rs/mwbot!14legoktmtitle2-fixmain
Extract usable title from Parsoid HTMLrepos/mwbot-rs/mwbot!13legoktmtitle-fixmain
Customize query in GitLab

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:08 PM
bzimport set Reference to bz1264.
bzimport added a subscriber: Unknown Object (MLST).

forgot to say this, the error is present on:

  • existing installation (after having changed the variable $wgMaxCredits to -1)
  • fresh installation, fresh database (with the variable $wgMaxCredits = -1)

jeluf wrote:

Fixed in Article.php, revision 1.257

Please test.

New error message is

database query syntax error has occurred. This may indicate a bug in the
software. The last attempted database query was:

SELECT rev_user, rev_user_text, user_real_name, MAX(rev_timestamp) as

timestamp FROM revision LEFT JOIN user ON rev_user = user_id WHERE rev_page = 1
AND old_user != 0 GROUP BY rev_user, rev_user_text, user_real_name ORDER BY
timestamp DESC

from within function "Article::getContributors". MySQL returned error "1054:
Unknown column 'old_user' in 'where clause'".

jeluf wrote:

replaced old_user by rev_user. Fixed.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:21 AM