Restart of a Python3.7 webservice on Toolforge results in a KeyError
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Fnielsen
	Feb 1 2023, 6:52 PM

Description

$ ssh toolforge
$ become scholia
$ webservice --backend=kubernetes -m 1G python3.7 restart
DEPRECATED: 'python3.7' type is deprecated.
  See https://wikitech.wikimedia.org/wiki/Help:Toolforge/Kubernetes
  for currently supported types.
Restarting...
Traceback (most recent call last):
  File "/usr/local/bin/webservice", line 517, in <module>
    job.request_restart()
  File "/usr/lib/python3/dist-packages/toolsws/backends/kubernetes.py", line 582, in request_restart
    self._get_live_deployment()["spec"], self._get_deployment()["spec"]
  File "/usr/lib/python3/dist-packages/toolsws/backends/kubernetes.py", line 237, in _containers_are_same
    if parse_quantity(traverse(first, key)) != parse_quantity(
  File "/usr/lib/python3/dist-packages/toolsws/backends/kubernetes.py", line 210, in traverse
    obj = obj[key]
KeyError: 'cpu'

I was expecting that the webservice should be restarted.

Details

	Subject	Repo	Branch	Lines +/-
	kubernetes: fix null handling	operations/software/tools-webservice	master	+9 -3
	kubernetes: Fix restart for some tools with default resources	operations/software/tools-webservice	master	+8 -1

Customize query in gerrit

Related Objects

Mentioned Here: T277495: webservice restart with k8s backend does not apply CPU or memory arguments

Event Timeline

Fnielsen created this task.Feb 1 2023, 6:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2023, 6:52 PM

Also tracked at https://github.com/WDscholia/scholia/issues/2237

This seems likely related to T277495: webservice restart with k8s backend does not apply CPU or memory arguments

@Fnielsen the quick work around is probably to webservice stop and then webservice --backend=kubernetes -m 1G python3.7 start. You might also benefit from making a webservice.template file so you don't have to remember all those CLI arguments in the future.