Trusted XFF string is incorrectly shown as untrusted in checkUserHelper.js
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 7 2023, 11:27 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The XFF string is marked as being untrusted regardless of whether it actually was or wasn't trusted.

What should have happened instead?:
It should accurately represent whether it is or isn't trusted.

Example:

	Subject	Repo	Branch	Lines +/-
	Use string key instead of boolean for whether an XFF is trusted	mediawiki/extensions/CheckUser	master	+8 -3

Dreamy_Jazz triaged this task as Medium priority.

Dreamy_Jazz updated the task description. (Show Details)

Change 887424 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use string key instead of boolean for whether an XFF is trusted

Change 887424 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use string key instead of boolean for whether an XFF is trusted

The above patch fixes the problem and has gone out in this weeks train.