Page MenuHomePhabricator
Create Task
Maniphest T329500

No match message does not check for last edit / logged action when using an IP target
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Load Special:CheckUser
  • Run either 'get edits' or 'get users' with an IP that has made edit, but this edit is no longer in the CheckUser tables (as it was removed).
  • Notice that the message shown does not include the timestamp of the last edit / logged action

Other information (browser name/version, screenshots, etc.):
The check performed in AbstractCheckUserPager::getEmptyBody is incorrect. Fixing this line will address this bug.

Details

SubjectRepoBranchLines +/-
Ensure last timestamp is shown when no matches found for an IPmediawiki/extensions/CheckUsermaster+3 -1
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Feb 13 2023, 11:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2023, 11:42 AM
Dreamy_Jazz renamed this task from No match message does not check for last edit / logged action when using an IP target but incorrectly does when using a XFF target to No match message does not check for last edit / logged action when using an IP target.Feb 13 2023, 11:42 AM
gerritbot added a comment.Feb 13 2023, 11:47 AM

Change 888661 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Ensure last timestamp is shown when no matches found for an IP

https://gerrit.wikimedia.org/r/888661

gerritbot added a project: Patch-For-Review.Feb 13 2023, 11:47 AM
Dreamy_Jazz claimed this task.Feb 13 2023, 11:47 AM
Dreamy_Jazz triaged this task as Medium priority.
Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.
Dreamy_Jazz moved this task from CheckUser to Patches for review on the CheckUser board.
gerritbot added a comment.May 20 2023, 8:25 AM

Change 888661 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Ensure last timestamp is shown when no matches found for an IP

https://gerrit.wikimedia.org/r/888661

Maintenance_bot removed a project: Patch-For-Review.May 20 2023, 8:31 AM
Dreamy_Jazz updated the task description. (Show Details)May 20 2023, 8:53 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 20 2023, 9:00 AM
Dreamy_Jazz closed this task as Resolved.May 20 2023, 9:36 AM
Dreamy_Jazz added a project: Wikimania-Hackathon-2023.
Dreamy_Jazz moved this task from Inbox to Hacking Projects on the Wikimania-Hackathon-2023 board.
Dreamy_Jazz moved this task from Patches for review to General / Unsorted on the CheckUser board.Jan 29 2024, 9:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL