Page MenuHomePhabricator

Allow GDPR consultant to see User roles in survey.wikimedia.it in long terms
Closed, ResolvedPublic

Description

The GPDR consultant of WMIT needs to monitor who has access to the platform and what are their privileges.

The problem was: our GDPR consultant should not be really a Super Administrator just to do that thing. Probably most people do this, but we don't like that, since the figure of a Super Administrator should be a technical one with write access to everything, and that is not really the definition of an external consultant that should just see in Read-Only the list of the Users and their access levels.

So, I implemented a fix in the WMIT LimeSurvey in order to allow people with "Users read" privileges to see Users' Role names. In order to comply with the libre license of LimeSurvey, I shared my patch under the same license, and I also proposed it upstream:

https://github.com/LimeSurvey/LimeSurvey/pull/3048

https://github.com/LimeSurvey/LimeSurvey/pull/3048/files

We can close this bug when:

  • we have a patch working in our local installation
  • LimeSurvey approved our patch
  • LimeSurvey approved our patch in their development branch
  • LimeSurvey landed our patch in master branch
  • we update our LimeSurvey and have fun

Note that, at the moment, we just implement that patch manually on server intreccio on this file:

/var/www/limesurvey/production/application/models/User.php

The current problem is: when we update, we obviously lose that change.

Event Timeline

valerio.bozzolan created this task.
valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan added a project: Upstream.

Interestingly this is the LimeSurvey's release schema:

LimeSurvey release schema.png (480×1 px, 36 KB)

https://manual.limesurvey.org/How_to_contribute_new_features#Release_process

It seems to me that enough time was passed, but our change is not in their master branch:

$ git checkout master
$ git log | grep "#18742"
<none>

So we are still in the develop branch.

$ git checkout develop
$ git log | grep -C 3 "#18742"
Author: Valerio Bozzolan <nsa+gitspam@<omissis>.cz>
Date:   Wed May 17 15:13:02 2023 +0200

    New Feature #18742: Allow "User Admins" to see Users' Roles (#3048)

    This feature helps GDPR lovers.

Sharing a small ping upstream

https://github.com/LimeSurvey/LimeSurvey/pull/3048#issuecomment-1627678304