Page MenuHomePhabricator

ENotifs mail come with wrong "oldid" revision numbers (one version too late)
Closed, ResolvedPublic

Description

Due to database redesign, this tiny change must be applied to let the Enotif mails come with the _correct_ link to
the diff between the last-visited-revision and the current revision. (Currently, the mail come with a pointer to
the diff between the first-not-yet-seen and the current revision, which makes no sense. This small bug was
apparently introduced during the recent database redesign but appears to be solved with this small patch).

Tom

  • for ENotif

Please (JeLuF or Hashar) can you fix this for me, thanks. I do not have CVS access rights.

RCS file: /cvsroot/wikipedia/phase3/includes/Article.php,v
retrieving revision 1.262
diff -u -b -r1.262 Article.php

  • includes/Article.php 19 Jan 2005 03:54:43 -0000 1.262

+++ includes/Article.php 20 Jan 2005 02:12:22 -0000
@@ -1040,7 +1040,7 @@

			$u->doUpdate(); 
		}
  • $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $me2, $now, $summary, $revisionId );

+ $this->showArticle( $text, wfMsg( 'updated' ), $sectionanchor, $me2, $now, $summary,
$lastRevision ); // old_id fix for new database scheme

		} 
		return $good; 
	}

Version: 1.5.x
Severity: normal

Details

Reference
bz1369
TitleReferenceAuthorSource BranchDest Branch
Remove unused "Owners" application from default settingsrepos/phabricator/deployment!24aklapperT336907wmf/stable
Remove unused "Packages" prototype application from default settingsrepos/phabricator/deployment!11aklapperaklapper-wmf/stable-patch-29473wmf/stable
toolforge-weld: allow setting a custom destination ip for hostnamerepos/cloud/toolforge/toolforge-weld!9raymond-ndibeadd_custom_fqdnmain
Revert v0.12.0 code for image-suggestionsrepos/data-engineering/airflow-dags!394xcollazoT336958-revert-0.12-image-suggestionsmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:11 PM
bzimport set Reference to bz1369.
bzimport added a subscriber: Unknown Object (MLST).