Page MenuHomePhabricator

Page-Move in mediawiki leaves pages behind
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue:

  • Create a page
  • Do a page move and select to keep a redirect

Observe:

We will have 2 pages in our system, the old and the new. On page move event we send a delete event also but we rely on a flag missing = true in api.
Because the redirect exists that flag wont be there and the old page won't be remove

Acceptance Criteria:

  • On Page move if redirect left behind, old page gets removed from system

Developer Notes:

  • Structured Data Article Delete event handler refactored to handle this edge case.

QA Process

  • I checked log and event messages over two days (Friday, July 28th and Monday July 31st) and the page-move handler seems to be performing as described.

Steps

  • I checked the structured-data-articledelete service cloudwatch logs for "redirect left behind after page-move" log messages.
  • I checked event-bridge-article-move topic and confirmed that the messages I saw with the redirect log were present.
  • I also checked event-bridge-article-delete topic and confirmed that the messages were there as well.
  • I checked the aws.strutctured-data.articles.v1 and also found the same messages.
  • Finally, I checked aws.structured-data.<project>-<namespace>-compacted.v1 for the last confirmation and also got a positive confirmation
  • I repeated the process several times and got the same consistency in results.

Event Timeline

REsquito-WMF updated the task description. (Show Details)
REsquito-WMF updated the task description. (Show Details)
REsquito-WMF updated the task description. (Show Details)
Felixejofre set the point value for this task to 5.Jun 21 2023, 1:50 PM