Maniphest T343264

Revert unused downstream Phab code to suppress triggering mail (predates silent batch-editing)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Aug 1 2023, 6:55 PM

Tags

Referenced Files

None

Subscribers

Description

Custom downstream rPHAB41c8bb0cec697f1e1a360fcc211d9d445cb4e8cf adding an metamta.can-suppress-mail config option should be reverted.
The account relying on this code got disabled in T280921 as functionality exists via batch edits nowadays (though requires CLI access).

(The other related patch in rPHAB8b7abb141a18f4f783416a6839881607418c1721 is irrelevant already as PhabricatorMailImplementationPHPMailerAdapter.php got axed in rPHAB10b91709c37ff59ec3c116f3c92eb4b27a96570e (2021) somehow without any reasons given, and in upstream in rPHABa8657e6ab6fd3feb3b880329f46df2a45b67dc82 (2019)).

Found by reading code diffs.

Details

	Title	Reference	Author	Source Branch	Dest Branch
	Revert "add needed config entry metamta.can-suppress-mail"	repos/phabricator/phabricator!12	aklapper	T343264revertSuppressNotifs	wmf/stable

Customize query in GitLab

Related Objects

Mentioned Here: rPHABa8657e6ab6fd: Update Postmark adapter for multiple mail media
T280921: Disable account @Phabricator_maintenance
rPHAB8b7abb141a18: Support suppressing email from select users.
rPHAB41c8bb0cec69: add needed config entry metamta.can-suppress-mail
rPHAB10b91709c37f: add ManiphestProjectTaskTransactionsConduitAPIMethod for #DataDataData

Event Timeline

Aklapper triaged this task as Low priority.Aug 1 2023, 6:55 PM

Aklapper created this task.

Aklapper updated the task description. (Show Details)

RhinosF1 subscribed.Aug 1 2023, 6:58 PM

Aklapper moved this task from Unsorted to Needs removal on the Technical-Debt board.Aug 1 2023, 6:58 PM

Aklapper moved this task from To Triage to Misc on the Phabricator board.

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/12

Revert "add needed config entry metamta.can-suppress-mail"

Aklapper claimed this task.Aug 2 2023, 9:14 AM

Aklapper added a project: Release-Engineering-Team (Priority Backlog 📥).

Aklapper updated the task description. (Show Details)Nov 28 2023, 4:33 PM

aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/12

Revert "add needed config entry metamta.can-suppress-mail"

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 5:10 PM

Aklapper moved this task from Misc to 2023-12-12 on the Phabricator board.Nov 29 2023, 9:50 PM

Aklapper edited projects, added Phabricator (2023-12-12); removed Phabricator.

Deployed as part of Phabricator (2023-12-12)