Page MenuHomePhabricator

Invalid HTML in category pages
Closed, ResolvedPublic

Description

Author: wegge

Description:
Apparently the W3C validator does not like an empty <ul></ul> pair.
The URL above will lead to the validation page. The problem lies within
CategoryPage.php, where an <ul> is emitted at the start of each column on
the page. Each time a starting letter is put into the column, the list is closed
with </ul>, and reopened again with <ul>. This is a problem at the
start of each column, since this leads to en empty <ul></ul>. The
attached patch against CVS REL1_4 solves this problem.

And yes, this is a minor cosmetic issue, but as I claimed that MW code was clean
on a danish webdesign newsgroup, I had to fix this, at least on my own Wiki. The
patch is already installed on my test Wiki,
http://playwiki.wegge.dk/Kategori:Teknik without problems.


Version: 1.4.x
Severity: minor
URL: http://validator.w3.org/check?uri=http%3A%2F%2Fwiki.wegge.dk%2FKategori%3ATeknik

Details

Reference
bz1457
TitleReferenceAuthorSource BranchDest Branch
tests: Add feed/v1 endpoint testsrepos/mediawiki/services/ipoid!102kharlanT345747-52d5main
Turn JS scripts into modulesrepos/mediawiki/services/ipoid!84tchandersuse-modulesmain
Define Phabricator as platform server name instead of Phorgerepos/phabricator/arcanist!1epicpupperepicpupper-wmf/stable-patch-77153wmf/stable
Add main running scriptrepos/mediawiki/services/ipoid!70stranadd-main-runtime-scriptmain
Add test to feed/v1 endpointsrepos/mediawiki/services/ipoid!65tsepothoabalaT345747main
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:10 PM
bzimport set Reference to bz1457.
bzimport added a subscriber: Unknown Object (MLST).

wegge wrote:

Patch against the CVS REL1_4 code.

Attached: