Page MenuHomePhabricator

don't offer undo links on edits that cannot be undone, or at least call them something different
Closed, DeclinedPublic

Description

On e.g.,
http://www.mediawiki.org/w/index.php?title=Anti-spam_features&action=history
we see plenty of "(undo)" links.
Well some of them are fine, however others are 'boobytrapped', telling users

"The edit could not be undone due to conflicting intermediate edits."

So perhaps don't offer the boobytrapped ones, or label them something
other than "undo"... if indeed it is computationally feasible.


Version: 1.20.x
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44311

Details

Reference
bz32779

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:59 PM
bzimport set Reference to bz32779.
bzimport added a subscriber: Unknown Object (MLST).

reachouttothetruth wrote:

My understanding of the undo process is that in order to determine whether an undo is possible, MediaWiki has to retrieve the full text of three revisions. If you're undoing one edit, that's acceptable. If you're viewing a history page containing 100 (or more) revisions and want to know whether each of them are undoable, that's not so good.

OK feel free to 'WONTFIX: too expensive'.