Page MenuHomePhabricator

Hardcoded Wikipedia strings in LanguageDa.php
Closed, DeclinedPublic

Description

Author: wegge

Description:
There are several cases of WikiPedia in the danish locale. The attached patch
contains fixed for the obvious changes, ie. [[Wikipedia:Foo]] -> [[Project:Foo]]
and "... Wikipedia ..." -> " ... {{SITENAME}} ..." There are a few Wikipedia
strings left that needs a little more thought.


Version: 1.4.x
Severity: normal

Details

Reference
bz1479
TitleReferenceAuthorSource BranchDest Branch
Turn benchmark tests back on and use new Avro versionrepos/abstract-wiki/wikifunctions/function-evaluator!200ecarggrace/T347901/fix-benchmark-testsmain
builds-builder: bump to 0.0.75-20231004081747-114d8c50repos/cloud/toolforge/toolforge-deploy!109sstefanovabump_builds-buildermain
inject-buildpacks: ensure the apt buildpack always runs firstrepos/cloud/toolforge/builds-builder!13sstefanovarun-apt-firstmain
Customize query in GitLab

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 8:12 PM
bzimport set Reference to bz1479.
bzimport added a subscriber: Unknown Object (MLST).

wegge wrote:

Patch against the CVS REL1_4 version

Attached:

Some problems with the patch.

You shouldn't use {{SITENAME}} for the project namespace; it's not reliable as the namespace may be set indepentently from
the site name. Instead, use 'Project' which is the canonical English form and will always be interpreted correctly in link
parsing.

Also, there are some links to log pages which need to be updated for 1.4 like this:
-Se [[Wikipedia:Sletningslog]] for en fortegnelse over nylige
+Se [[{{SITENAME}}:Sletningslog]] for en fortegnelse over nylige
that should be pointing now at [[Special:Log/delete]]

wegge wrote:

Work is in progress on the danish wikipedia to bring LanguageDa.php up to date,
so this patch is no longer relevant.

Diffusion changed the task status from Declined to Resolved by committing Unknown Object (Diffusion Commit).Mar 4 2015, 8:22 AM
Diffusion added a commit: Unknown Object (Diffusion Commit).
Aklapper changed the task status from Resolved to Declined.Mar 4 2015, 5:44 PM
Aklapper claimed this task.