Page MenuHomePhabricator
Create Task
Maniphest T350002

Prometheus production should fail with unset replica label
Closed, ResolvedPublic
Actions

Description

An unset prometheus::replica_label is a problem because it causes overlapping blocks in thanos compactor. At this point we should just require that replica label is always set, or fail puppet otherwise.

Details

SubjectRepoBranchLines +/-
prometheus: require replica_label to be setoperations/puppetproduction+6 -6
Customize query in gerrit

Related Objects

Event Timeline

fgiunchedi created this task.Oct 30 2023, 9:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2023, 9:25 AM
gerritbot added a comment.Oct 30 2023, 9:26 AM

Change 969685 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] prometheus: require replica_label to be set

https://gerrit.wikimedia.org/r/969685

gerritbot added a project: Patch-For-Review.Oct 30 2023, 9:26 AM
gerritbot added a comment.Oct 30 2023, 10:59 AM

Change 969685 merged by Filippo Giunchedi:

[operations/puppet@production] prometheus: require replica_label to be set

https://gerrit.wikimedia.org/r/969685

fgiunchedi closed this task as Resolved.Oct 30 2023, 11:00 AM
fgiunchedi claimed this task.
fgiunchedi added a subscriber: taavi.

Done, thank you @taavi

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2023, 11:10 AM
fgiunchedi mentioned this in T335406: ThanosCompactHalted error on overlapping blocks.Oct 31 2023, 8:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL