Untranslated strings in OATHAuth notification email
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

None

Authored By

	NekoCharm
	Nov 8 2023, 2:52 PM

Description

Steps to replicate the issue (include links if applicable):

Enable TOTP;
Disable it;

What happens?:
An email sent with an untranslated string (showing message key).

What should have happened instead?:
The string should be translated.

Software version (skip for WMF-hosted wikis like Wikipedia):
master, REL1_39, REL1_40, REL1_41

Other information (browser name/version, screenshots, etc.):

ABB36913A263BC1292A6E1341D7529F9.jpg (1×1 px, 75 KB)

Related Objects

Mentioned Here: T326073: Missing oathauth-notifications-disable-primary message

Event Timeline

NekoCharm created this task.Nov 8 2023, 2:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2023, 2:53 PM

In src/Notifications/DisablePresentationModel.php:

	public function getPrimaryLink() {
		return [
			'url' => SpecialPage::getTitleFor( 'Preferences' )->getLocalURL(),
			'label' => $this->msg( 'oathauth-notifications-disable-primary' )->text()
		];
	}

but there is no such key even in en.json.

Aklapper added a project: MediaWiki-extensions-OATHAuth.Nov 8 2023, 3:04 PM

Found a duplicated bug report T326073 which has not been resolved since August

Aklapper closed this task as a duplicate of T326073: Missing oathauth-notifications-disable-primary message.Nov 8 2023, 5:25 PM

	F41471976: ABB36913A263BC1292A6E1341D7529F9.jpg
	Nov 8 2023, 2:52 PM

Untranslated strings in OATHAuth notification emailClosed, DuplicatePublicBUG REPORTActions

Description

Related Objects

Event Timeline

Untranslated strings in OATHAuth notification email
Closed, DuplicatePublicBUG REPORT
Actions