Page MenuHomePhabricator

Remove custom go-get / go-import code in Diffusion repositories
Closed, ResolvedPublic

Description

<andre>if you by any chance remember usecases for https://phabricator.wikimedia.org/source/scap/?go-get=1 in https://phabricator.wikimedia.org/D775 and https://phabricator.wikimedia.org/D776 , I'd love to hear if these use cases are still valid six years later or if we can scrap that custom code.

<dduvall> tl;dr: scrap it! it's needed by the go toolchain to resolve a git repo from a module path and version string. since we no longer (or are trying not to) host repos using diffusion, it shouldn't be needed

(not hosting in Diffusion is basically T191182)

Details

TitleReferenceAuthorSource BranchDest Branch
Remove custom go-get / go-import code in Diffusion repositoriesrepos/phabricator/extensions!34aklapperrmGoGetT352322wmf/stable
Remove custom go-get / go-import code in Diffusion repositoriesrepos/phabricator/phabricator!25aklapperT352322gowmf/stable
Customize query in GitLab

Event Timeline

Aklapper created this task.

As the two Differential changes do not reliably link to merged commits, here's what I believe are related code changes:

which seem to have seen further changes down the line, sigh

Note to myself: Also remove corresponding code in rPHEX afterwards

Aklapper edited projects, added Phabricator (2024-01-16); removed Phabricator.

Deployed on 2024-01-16

This got deployed today on 2024-05-14.