Page MenuHomePhabricator

Expose Prometheus Blackbox Exporter's ability to add http headers in puppet module
Closed, ResolvedPublic

Description

While working through T347355 , we noticed that the prometheus pollers do not send an Accept: header by default. While the blackbox exporter does support adding arbitrary headers, this feature is not yet exposed in our prometheus::blackbox::check::http Puppet resource .

Creating this ticket to:

  • Add the feature
  • Verify operation

Event Timeline

bking renamed this task from Expose Prometheus Blackbox's ability to add http headers in puppet module to Expose Prometheus Blackbox Exporter's ability to add http headers in puppet module.Dec 18 2023, 7:52 PM

Change 983948 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] wdqs ldf: remove useragent param

https://gerrit.wikimedia.org/r/983948

Change 983949 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] prometheus-blackbox: Expose ability to add arbitrary headers

https://gerrit.wikimedia.org/r/983949

Change 983949 abandoned by Bking:

[operations/puppet@production] prometheus-blackbox: Expose ability to add arbitrary headers

Reason:

superseded by 983948

https://gerrit.wikimedia.org/r/983949

Change 983947 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] wdqs ldf: remove useragent param

https://gerrit.wikimedia.org/r/983947

Change 983947 merged by Bking:

[operations/puppet@production] wdqs ldf: remove useragent param

https://gerrit.wikimedia.org/r/983947

Change 983948 merged by Bking:

[operations/puppet@production] prometheus-blackbox: Expose ability to add arbitrary headers

https://gerrit.wikimedia.org/r/983948

Change 984212 had a related patch set uploaded (by Bking; author: Bking):

[operations/puppet@production] wdqs: Add Accept: header to LDF endpoint check

https://gerrit.wikimedia.org/r/984212

bking changed the task status from Open to In Progress.Dec 19 2023, 4:51 PM
bking claimed this task.
bking triaged this task as Medium priority.

Change 984212 merged by Bking:

[operations/puppet@production] wdqs: Add Accept: header to LDF endpoint check

https://gerrit.wikimedia.org/r/984212

bking moved this task from 2023.12.01 - 2023.12.31 to Observability on the Data-Platform-SRE board.

Based on the access log on wdqs1015 and the rendered Prometheus config in /etc/prometheus/blackbox.yml.d/query_wikidata_org_ldf.yml , this change appears to be working. As such, I'm closing out this ticket.