Page MenuHomePhabricator

Update ConfirmEdit README.md to use namespaced class names
Closed, ResolvedPublicBUG REPORT

Description

See https://gerrit.wikimedia.org/g/mediawiki/extensions/ConfirmEdit - the readme mentions some possible settings with defaults which are outdated. In particular, the suggested $wgCaptchaStorageClass no longer exists.

Update the information where appropriate based on the information in extension.json.

Event Timeline

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)

Thank you for taking this on. Let me know if you have any questions or anything is unclear.

Hello,

Please clear my doubts.

In above description, it's mentioned " In particular, the suggested $wgCaptchaStorageClass no longer exists." , but i found the updated path in extension.json.

Should $wgCaptchaStorageClass be removed or updated. I have attached the snapshot for reference.

captha.png (195×1 px, 36 KB)

Sincerely,
Abhishek

The description in README.md should be updated to use the new names for CaptchaSessionStore & CaptchaCacheStore

We use Gerrit for code review, not tiny screenshots of editors in Phabricator comments.

@Abhii5599 Thanks for taking a look at the code! Please use developer access to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review and provide feedback. If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader.

Change #1074982 had a related patch set uploaded (by Obamwonyi; author: Obamwonyi):

[mediawiki/extensions/ConfirmEdit@master] component: Update ConfirmEdit README.md to use namespaced class names

https://gerrit.wikimedia.org/r/1074982

Change #1074982 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] component: Update ConfirmEdit README.md to use namespaced class names

https://gerrit.wikimedia.org/r/1074982

Hi, please I have submitted a patch for this, and it has been merged, but the status is still flagged as a bug, so I don't know if there is something else to fix?

kostajh assigned this task to Destiny.
kostajh subscribed.

Thanks @Destiny!

You're welcome Sir, do have a great day.