Page MenuHomePhabricator

daily_account_consistency_check failes due to empty group
Closed, ResolvedPublic

Description

Because the sre-admins: is empty, but anchored in datacenter-ops, cross consistency check fails. This is because the result is an empty list added as a member to the datacenter-ops member list.

YAML parsing is weird.

Systemd timer ran the following command:

   /usr/local/bin/cross-validate-accounts

Its return value was 1 and emitted the following output:

Traceback (most recent call last):
 File "/usr/local/bin/cross-validate-accounts", line 374, in <module>
   main()
 File "/usr/local/bin/cross-validate-accounts", line 358, in main
   validate_common_ops_group(yamldata),
 File "/usr/local/bin/cross-validate-accounts", line 172, in validate_common_ops_group
   + yamldata['groups']['fr-tech-admins']['members']
TypeError: unhashable type: 'list'

Event Timeline

Change 1008809 had a related patch set uploaded (by Slyngshede; author: Slyngshede):

[operations/puppet@production] P:openldap::management Unbreak cross validation script.

https://gerrit.wikimedia.org/r/1008809

Change 1008809 merged by Slyngshede:

[operations/puppet@production] P:openldap::management Unbreak cross validation script.

https://gerrit.wikimedia.org/r/1008809

SLyngshede-WMF triaged this task as Medium priority.