Page MenuHomePhabricator

CookieWarning does not load styles; load.php adds error comment
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • use a fresh MW 1.39.6 mediawiki installation and enable the CookieWarning extension

What happens?:
styles are not loaded via resource loader, inspecting the stylesheets via the browser's style inspector shows the following error message for load.php

/*
[8340c28558503eb2903247cc] /load.php?lang=en&modules=ext.CookieWarning.styles%7Cext.newPageInCategory.styles%7Cext.visualEditor.desktopArticleTarget.noscript%7Cmediawiki.htmlform.styles%7Cmediawiki.special.userlogin.common.styles%7Cmediawiki.special.userlogin.login.styles%7Cmediawiki.ui%7Cmediawiki.ui.button%2Ccheckbox%2Cinput%2Cradio%7Cmediawiki.widgets.styles%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui.styles.indicators&only=styles&skin=flowwiki   Less_Exception_Compiler: variable @z-index-overlay is undefined in file /var/www/mediawiki/extensions/CookieWarning/resources/ext.CookieWarning/ext.CookieWarning.less in ext.CookieWarning.less on line 11, column 11
09| 	left: 0;
10| 	width: 100%;
11| 	z-index: @z-index-overlay;
12| 	display: flex;
13| 	justify-content: center;
14| 
Backtrace:
from /var/www/mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Variable.php(48)
#0 /var/www/mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Expression.php(51): Less_Tree_Variable->compile()
#1 /var/www/mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Value.php(26): Less_Tree_Expression->compile()
#2 /var/www/mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Rule.php(73): Less_Tree_Value->compile()
#3 /var/www/mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(91): Less_Tree_Rule->compile()
#4 /var/www/mediawiki/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(91): Less_Tree_Ruleset->compile()
#5 /var/www/mediawiki/vendor/wikimedia/less.php/lib/Less/Parser.php(190): Less_Tree_Ruleset->compile()
#6 /var/www/mediawiki/includes/ResourceLoader/FileModule.php(1127): Less_Parser->getCss()
#7 /var/www/mediawiki/includes/ResourceLoader/FileModule.php(1010): MediaWiki\ResourceLoader\FileModule->compileLessString()
#8 /var/www/mediawiki/includes/ResourceLoader/FileModule.php(986): MediaWiki\ResourceLoader\FileModule->processStyle()
#9 /var/www/mediawiki/includes/ResourceLoader/FileModule.php(964): MediaWiki\ResourceLoader\FileModule->readStyleFile()
#10 /var/www/mediawiki/includes/ResourceLoader/FileModule.php(396): MediaWiki\ResourceLoader\FileModule->readStyleFiles()
#11 /var/www/mediawiki/includes/ResourceLoader/Module.php(834): MediaWiki\ResourceLoader\FileModule->getStyles()
#12 /var/www/mediawiki/includes/ResourceLoader/Module.php(786): MediaWiki\ResourceLoader\Module->buildContent()
#13 /var/www/mediawiki/includes/ResourceLoader/ResourceLoader.php(1118): MediaWiki\ResourceLoader\Module->getModuleContent()
#14 /var/www/mediawiki/includes/ResourceLoader/ResourceLoader.php(820): MediaWiki\ResourceLoader\ResourceLoader->makeModuleResponse()
#15 /var/www/mediawiki/load.php(53): MediaWiki\ResourceLoader\ResourceLoader->respond()
#16 /var/www/mediawiki/load.php(39): wfLoadMain()
#17 {main}

Problematic modules: {"ext.CookieWarning.styles":"error"}
*/

What should have happened instead?:
styles are loaded correctly

Software version :

I placed the mediawiki.skin.variables.less into my skin and imported the default styles via @import 'mediawiki.skin.default.less';. However in MW 1.39.6 the mediawiki.skin.default.less does not contain a variable @z-index-overlay. When i add the variable into mediawiki core's mediawiki.skin.defaults.less everything works as expected.

Event Timeline

Schtom renamed this task from CookieWarning does not load styles; load.php throws error to CookieWarning does not load styles; load.php adds error comment.Mar 6 2024, 1:29 PM