Page MenuHomePhabricator

System field not cleared when key is deactivated
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Add a SSH key via https://idm.wikimedia.org/keymanagement/
  • Note "system" field is empty
  • Activate it on "Wikimedia Cloud Services SSH keys"
  • Note "system" field is showing "Wikimedia Cloud Services SSH keys"
  • Deactivate key
  • Look at "system" field again

What happens?:
System field still lists "Wikimedia Cloud Services SSH keys"

What should have happened instead?:
System field is empty, since the key is not active on any systems

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think a good way of showing this information would be to merge the current "Active" and "System" fields, to a single status field that could show "Active on <system>" or "Inactive".

SLyngshede-WMF triaged this task as High priority.

Change #1014475 had a related patch set uploaded (by Slyngshede; author: Slyngshede):

[operations/software/bitu@master] Clear system field on deactivation.

https://gerrit.wikimedia.org/r/1014475

Change #1014475 merged by Slyngshede:

[operations/software/bitu@master] Clear system field on deactivation.

https://gerrit.wikimedia.org/r/1014475

SLyngshede-WMF moved this task from Pending Release to Resolved on the Bitu board.