stewardbot KeyError: 0
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	AntiCompositeNumber
	Mar 22 2024, 3:48 PM

Description

2024-03-22T15:45:55Z stewardbot ERROR: Recent changes listener encountered an error
Traceback (most recent call last):
  File "/data/project/stewardbots/stewardbots/StewardBot/StewardBot.py", line 1183, in start
    expiry = change["log_params"][0]
KeyError: 0
2024-03-22T15:45:55Z stewardbot INFO: Starting EventStream listener

Caused by https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=55494467

Details

Subject	Repo	Branch	Lines +/-
Fix log_action	labs/tools/stewardbots	master	+9 -3
Fix log_action as well	labs/tools/stewardbots	master	+15 -0
Fix log_action as well	labs/tools/stewardbots	master	+5 -3
Fix log_params issue causing StewardBot to crash	labs/tools/stewardbots	master	+2 -2

Customize query in gerrit

Event Timeline

AntiCompositeNumber created this task.Mar 22 2024, 3:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2024, 3:48 PM

Looking further at the logs, it's happening for every global block.

Sounds like a change in the log format? The wmf.23 changelog points towards https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalBlocking/+/1007909...

{
  "$schema": "/mediawiki/recentchange/1.0.0",
  "meta": {
    "uri": "https://meta.wikimedia.org/wiki/User:13.105.28.0/23",
    "request_id": "fdac3c05-d6f9-4053-abca-e1bb61c10322",
    "id": "20cccbb1-c06e-4bdc-9aae-7e266cc3aa65",
    "dt": "2024-03-22T16:29:51Z",
    "domain": "meta.wikimedia.org",
    "stream": "mediawiki.recentchange",
    "topic": "eqiad.mediawiki.recentchange",
    "partition": 0,
    "offset": 4965559158
  },
  "id": 30476671,
  "type": "log",
  "namespace": 2,
  "title": "User:13.105.28.0/23",
  "title_url": "https://meta.wikimedia.org/wiki/User:13.105.28.0/23",
  "comment": "[[m:NOP|Open proxy/Webhost]]: Visit the [[m:WM:OP/H|FAQ]] if you are affected <!-- Microsoft Azure -->",
  "timestamp": 1711124991,
  "user": "AntiCompositeNumber",
  "bot": false,
  "log_id": 55494762,
  "log_type": "gblblock",
  "log_action": "gblock",
  "log_params": {
    "expiry": "20270122162951",
    "flags": []
  },
  "log_action_comment": "AntiCompositeNumber globally blocked 13.105.28.0/23 with an expiration time of 16:29, 22 January 2027 : [[m:NOP|Open proxy/Webhost]]: Visit the [[m:WM:OP/H|FAQ]] if you are affected <!-- Microsoft Azure -->",
  "server_url": "https://meta.wikimedia.org",
  "server_name": "meta.wikimedia.org",
  "server_script_path": "/w",
  "wiki": "metawiki",
  "parsedcomment": "<a href=\"https://meta.wikimedia.org/wiki/NOP\" class=\"extiw\" title=\"m:NOP\">Open proxy/Webhost</a>: Visit the <a href=\"https://meta.wikimedia.org/wiki/WM:OP/H\" class=\"extiw\" title=\"m:WM:OP/H\">FAQ</a> if you are affected &lt;!-- Microsoft Azure --&gt;"
}

yup, looks like log_params is now an object with named values instead of an array. Gotta love un-announced breaking changes.

Change #1013612 had a related patch set uploaded (by Operator873; author: Operator873):

[labs/tools/stewardbots@master] Fix log_params issue causing StewardBot to crash

https://gerrit.wikimedia.org/r/1013612

gerritbot added a project: Patch-For-Review.Mar 22 2024, 10:54 PM

Change #1013612 merged by jenkins-bot:

[labs/tools/stewardbots@master] Fix log_params issue causing StewardBot to crash

https://gerrit.wikimedia.org/r/1013612

Fix is merged, patch is live. StewardBot restarted. Awaiting verification of results.

Operator873 changed the task status from Open to In Progress.Mar 22 2024, 11:14 PM

Operator873 claimed this task.

here's a modify and a remove for the record

{
  "$schema": "/mediawiki/recentchange/1.0.0",
  "meta": {
    "uri": "https://meta.wikimedia.org/wiki/User:192.0.2.1",
    "request_id": "516ec711-ddc3-40c2-ae90-ab3bb2ec77ae",
    "id": "22c81925-0043-45fc-9e78-7e4471201489",
    "dt": "2024-03-22T20:07:32Z",
    "domain": "meta.wikimedia.org",
    "stream": "mediawiki.recentchange",
    "topic": "eqiad.mediawiki.recentchange",
    "partition": 0,
    "offset": 4965968820
  },
  "id": 30478275,
  "type": "log",
  "namespace": 2,
  "title": "User:192.0.2.1",
  "title_url": "https://meta.wikimedia.org/wiki/User:192.0.2.1",
  "comment": "testing [[phab:T360790]]",
  "timestamp": 1711138052,
  "user": "AntiCompositeNumber",
  "bot": false,
  "log_id": 55496195,
  "log_type": "gblblock",
  "log_action": "modify",
  "log_params": {
    "expiry": "20240405200732",
    "flags": []
  },
  "log_action_comment": "AntiCompositeNumber changed global block settings for 192.0.2.1 with an expiration time of 20:07, 5 April 2024 : testing [[phab:T360790]]",
  "server_url": "https://meta.wikimedia.org",
  "server_name": "meta.wikimedia.org",
  "server_script_path": "/w",
  "wiki": "metawiki",
  "parsedcomment": "testing <a href=\"https://phabricator.wikimedia.org/T360790\" class=\"extiw\" title=\"phab:T360790\">phab:T360790</a>"
}

{
  "$schema": "/mediawiki/recentchange/1.0.0",
  "meta": {
    "uri": "https://meta.wikimedia.org/wiki/User:192.0.2.1",
    "request_id": "a32c74fe-0d73-42c0-9d5c-7087fa2c4463",
    "id": "7381f67a-cf1c-45c5-89f3-a5df0b65e252",
    "dt": "2024-03-22T23:41:42Z",
    "domain": "meta.wikimedia.org",
    "stream": "mediawiki.recentchange",
    "topic": "eqiad.mediawiki.recentchange",
    "partition": 0,
    "offset": 4966366619
  },
  "id": 30479585,
  "type": "log",
  "namespace": 2,
  "title": "User:192.0.2.1",
  "title_url": "https://meta.wikimedia.org/wiki/User:192.0.2.1",
  "comment": "test",
  "timestamp": 1711150902,
  "user": "AntiCompositeNumber",
  "bot": false,
  "log_id": 55497580,
  "log_type": "gblblock",
  "log_action": "gunblock",
  "log_params": [],
  "log_action_comment": "AntiCompositeNumber removed the global block on 192.0.2.1: test",
  "server_url": "https://meta.wikimedia.org",
  "server_name": "meta.wikimedia.org",
  "server_script_path": "/w",
  "wiki": "metawiki",
  "parsedcomment": "test"
}