Maniphest T361600

Make sure all RouteHandler consts are private unless other RouteHandlers use them.
Closed, ResolvedPublic
Actions

Description

An example of a public route handler const that is used in another route handler:
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/58097985ca780752786f5b1672ae4724008f2137/repo/rest-api/src/RouteHandlers/AddItemStatementRouteHandler.php#L183

Details

	Subject	Repo	Branch	Lines +/-
	REST: Make RouteHandler consts private	mediawiki/extensions/Wikibase	master	+129 -133

Customize query in gerrit

Event Timeline

Muhammad_Yasser_Jazirahly_WMDE created this task.Apr 2 2024, 2:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2024, 2:19 PM

Change #1024982 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Make RouteHandler consts private

https://gerrit.wikimedia.org/r/1024982

gerritbot added a project: Patch-For-Review.Apr 28 2024, 8:22 PM

Change #1024982 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make RouteHandler consts private

https://gerrit.wikimedia.org/r/1024982

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2024, 2:30 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 29 2024, 3:00 AM

Jakob_WMDE moved this task from Tech backlog to Sprint 18 on the Wikibase Product Platform Team WPP board.Apr 29 2024, 3:52 AM

Jakob_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 18); removed Wikibase Product Platform Team WPP.

Jakob_WMDE assigned this task to Muhammad_Yasser_Jazirahly_WMDE.Apr 29 2024, 3:55 AM

Jakob_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 18) board.

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 18) board.

Ifrahkhanyaree_WMDE closed this task as Resolved.Apr 30 2024, 10:58 AM