Page MenuHomePhabricator
Create Task
Maniphest T362053

Make MediaModeration sleep on JobQueueError
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The MediaModeration script stopped running over the weekend because of the following error:

JobQueueError from line 134 of /srv/mediawiki/php-1.42.0-wmf.25/extensions/EventBus/includes/Adapters/JobQueue/JobQueueEventBus.php:
Could not enqueue jobs
#0 /srv/mediawiki/php-1.42.0-wmf.25/includes/jobqueue/JobQueue.php(375): MediaWiki\Extension\EventBus\Adapters\JobQueue\JobQueueEventBus->doBatchPush(Array, 0)
#1 /srv/mediawiki/php-1.42.0-wmf.25/includes/jobqueue/JobQueue.php(347): JobQueue->batchPush(Array, 0)
#2 /srv/mediawiki/php-1.42.0-wmf.25/includes/jobqueue/JobQueueGroup.php(155): JobQueue->push(Array)
#3 /srv/mediawiki/php-1.42.0-wmf.25/extensions/MediaModeration/maintenance/scanFilesInScanTable.php(116): JobQueueGroup->push(Array)
#4 /srv/mediawiki/php-1.42.0-wmf.25/maintenance/includes/MaintenanceRunner.php(698): MediaWiki\Extension\MediaModeration\Maintenance\ScanFilesInScanTable->execute()
#5 /srv/mediawiki/php-1.42.0-wmf.25/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#6 /srv/mediawiki/multiversion/MWScript.php(158): require_once('/srv/mediawiki/...')
#7 {main}

When this happens, the script should be instructed to sleep and then re-try inserting jobs to avoid the script exiting due to temporary server disruptions.

Acceptance criteria
  • The scanFilesInScanTable.php script should catch thrown JobQueueError exceptions and instead sleep before re-trying an insert.

Details

SubjectRepoBranchLines +/-
Catch JobQueueError exceptions in scanFilesInScanTable.phpmediawiki/extensions/MediaModerationmaster+38 -4
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Apr 8 2024, 10:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2024, 10:21 AM
Dreamy_Jazz claimed this task.Apr 8 2024, 10:21 AM
Dreamy_Jazz set the point value for this task to 1.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
gerritbot added a comment.Apr 8 2024, 10:38 AM

Change #1017818 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Catch JobQueueError exceptions in scanFilesInScanTable.php

https://gerrit.wikimedia.org/r/1017818

gerritbot added a project: Patch-For-Review.Apr 8 2024, 10:39 AM
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Apr 8 2024, 10:59 AM
gerritbot added a comment.Apr 8 2024, 11:31 AM

Change #1017818 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Catch JobQueueError exceptions in scanFilesInScanTable.php

https://gerrit.wikimedia.org/r/1017818

Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.Apr 8 2024, 11:34 AM

It will be hard to QA this, because it would require some specific circumstances which would not be possible to QA on beta wikis and hard to QA on test wikis.

As such, I'm proposing to skip QA.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Apr 8 2024, 12:00 PM
Dreamy_Jazz closed this task as Resolved.Apr 10 2024, 1:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL