Steps to replicate the issue (include links if applicable):
Revscoring models fail with the following logs.
Traceback (most recent call last):
File "/srv/rev/revscoring_model/model.py", line 8, in <module>
from revscoring_model.model_servers import (
File "/srv/rev/revscoring_model/model_servers/__init__.py", line 1, in <module>
from .model_server_mp import RevscoringModelMP
File "/srv/rev/revscoring_model/model_servers/model_server_mp.py", line 8, in <module>
from model_servers import RevscoringModel, RevscoringModelType
File "/srv/rev/revscoring_model/model_servers/__init__.py", line 1, in <module>
from .model_server_mp import RevscoringModelMP
File "/srv/rev/revscoring_model/model_servers/model_server_mp.py", line 8, in <module>
from model_servers import RevscoringModel, RevscoringModelType
ImportError: cannot import name 'RevscoringModel' from partially initialized module 'model_servers' (most likely due to a circular import) (/srv/rev/revscoring_model/model_servers/__init__.py)What happens?:
A circular import happens after reording imports in a previous patch that we formatted all imports using isort https://gerrit.wikimedia.org/r/c/machinelearning/liftwing/inference-services/+/981718