Author: avarab
Description:
using <br clear=all> breaks XHTML compilance. This patch fixes the issue.
Version: 1.5.x
Severity: blocker
Platform: Other
Description
Description
Details
Details
- Reference
- bz1661
Revisions and Commits
Revisions and Commits
| Unknown Object (Diffusion Commit) |
Event Timeline
Comment Actions
avarab wrote:
The patch against includes/Parser.php (for REL1_4)
The patch against REL1_4.
Attached:
Comment Actions
avarab wrote:
A testcase for the regular expression
A testcase for the expression.
Attached:
Comment Actions
Several things wrong with this patch:
First, it does not appear to be notice-clean. With error_reporting set to E_ALL,
notices will be displayed about the use of undefined constants.
Second, it will fail to pick up any <br> containing additional attributes (for
instance, an id or a style attribute) so it is insufficient.
Third, it gratuitously transforms the clear attribute to an inline style. This is
unnecessary for our XHTML 1.0 Transitional target. (If it were necessary, it would
also be necessary to be able to merge it with a specified style attribute if present.)
Consider instead working on Sanitizer.php to have the HTML sanitizer output the
/> automatically on manditorily-closed empty elements.
Comment Actions
avarab wrote:
- It isn't, I didn't test it for that.
- No it won't, it was designed for this specific case and you're right, it's
insufficient.
- This is what currently happens if you type <br clear="both"/>, the wiki will
render <br style="clear: both;" />, however if you type <br clear="all" /> or
<br clear="all"> it will output what you gave it.
- Sanitizer.php is probably better, any suggestions as to where to start?