Page MenuHomePhabricator

Confusing output from fixTrailingSpacesInLogs.php on MediaWiki update when cu_log is empty
Closed, ResolvedPublic1 Estimated Story Points

Description

When updating MediaWiki with CheckUser also installed, the fixTrailingSpacesInLogs.php script is run. However, if there are no rows in the cu_log table the output is confusing. The output is:

Processed 200 rows out of .

This is run on every CI run as part of the installation of MediaWiki before running tests. As such, fixing the output makes it clearer which script is printing this information in case anyone wants to inspect it.

Event Timeline

Change #1038406 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Exit early from fixTrailingSpacesInLogs.php if no cu_log rows

https://gerrit.wikimedia.org/r/1038406

Change #1038406 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Exit early from fixTrailingSpacesInLogs.php if no cu_log rows

https://gerrit.wikimedia.org/r/1038406