Page MenuHomePhabricator
Create Task
Maniphest T366617

Special:UserMerge does not meet TransactionProfiler expectations
Open, Needs TriagePublic
Actions

Description

The MediaWiki-extensions-UserMerge extension does not meet the TransactionProfiler expectations when using Special:UserMerge. This is because SpecialUserMerge::doesWrites returns false (the default), where it should actually return true (as the special page does write cause writes to the DB).

Details

SubjectRepoBranchLines +/-
Define SpecialUserMerge::doesWrites as to return truemediawiki/extensions/UserMergemaster+7 -0
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Tue, Jun 4, 4:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Jun 4, 4:04 PM
gerritbot added a comment.Tue, Jun 4, 4:06 PM

Change #1038863 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/UserMerge@master] Define SpecialUserMerge::doesWrites as to return true

https://gerrit.wikimedia.org/r/1038863

gerritbot added a project: Patch-For-Review.Tue, Jun 4, 4:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL