Page MenuHomePhabricator
Create Task
Maniphest T367070

Fix "mul" language code handling
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

"mul" is a valid language code for labels and aliases, but not for descriptions. We're currently using WikibaseRepo::getTermsLanguages( $services )->getLanguages() for both, which can't be right.

We should change our code so that there is no generic LanguageCodeValidator, because whether a language code is valid or not depends on what it is being used for.

Details

SubjectRepoBranchLines +/-
REST: Use term type specific path param validatorsmediawiki/extensions/Wikibasemaster+166 -52
REST: Use term type specific path param validatorsmediawiki/extensions/Wikibasemaster+167 -54
REST: Add "mul" language code handling e2e testsmediawiki/extensions/Wikibasemaster+33 -8
REST: Use term type specific validatorsmediawiki/extensions/Wikibasemaster+197 -192
Customize query in gerrit

Event Timeline

Jakob_WMDE created this task.Jun 10 2024, 3:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2024, 3:14 PM
Ifrahkhanyaree_WMDE moved this task from Incoming tickets outside WPP to Ready for planning on the Wikibase Product Platform Team WPP board.Jun 11 2024, 9:48 AM
Ifrahkhanyaree_WMDE set the point value for this task to 5.Jun 11 2024, 10:00 AM
Ifrahkhanyaree_WMDE added a project: Wikibase REST API (WPP).
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 22 on the Wikibase Product Platform Team WPP board.
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 22); removed Wikibase Product Platform Team WPP.
Jakob_WMDE added a comment.EditedJun 12 2024, 12:53 PM

Task breakdown notes:

  • create one interface for each labels, descriptions and aliases, but reuse the same (existing) implementation
  • create one service wiring entry for each
  • use the new validators in all deserializers
  • use the new validators in all RequestValidatingDeserializers
    • split LanguageCodeRequest into three accordingly
  • this may not be enabled in CI yet so creating an e2e test (that passes in CI) might not be straightforward. Talk to the WD team :)
  • setting name: tmpEnableMulLanguageCode
  • getDefaultTermsLanguages returns mul if it is configured which is confusing since it's not valid for all kinds of terms. It would be nice to have this cleaned up in the rest of Wikibase as well. We should talk to the WD team about it or at least make sure there is a ticket.
Jakob_WMDE claimed this task.Jun 14 2024, 8:07 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 22) board.
gerritbot added a comment.Jun 14 2024, 10:17 AM

Change #1043700 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use term type specific validators

https://gerrit.wikimedia.org/r/1043700

gerritbot added a project: Patch-For-Review.Jun 14 2024, 10:17 AM
gerritbot added a comment.Jun 14 2024, 1:03 PM

Change #1043767 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add "mul" language code handling e2e tests

https://gerrit.wikimedia.org/r/1043767

gerritbot added a comment.Jun 18 2024, 11:28 AM

Change #1047048 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use term type specific path param validators

https://gerrit.wikimedia.org/r/1047048

gerritbot added a comment.Jun 18 2024, 11:31 AM

Change #1043700 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use term type specific validators

https://gerrit.wikimedia.org/r/1043700

gerritbot added a comment.Jun 18 2024, 2:40 PM

Change #1043767 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add "mul" language code handling e2e tests

https://gerrit.wikimedia.org/r/1043767

gerritbot added a comment.Jun 18 2024, 2:55 PM

Change #1047102 had a related patch set uploaded (by Ollie Shotton; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use term type specific path param validators

https://gerrit.wikimedia.org/r/1047102

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 18 2024, 3:00 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 22) board.Jun 18 2024, 3:01 PM
gerritbot added a comment.Jun 18 2024, 4:23 PM

Change #1047102 abandoned by Ollie Shotton:

[mediawiki/extensions/Wikibase@master] REST: Use term type specific path param validators

Reason:

https://gerrit.wikimedia.org/r/1047102

gerritbot added a comment.Jun 19 2024, 8:57 AM

Change #1047048 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use term type specific path param validators

https://gerrit.wikimedia.org/r/1047048

Maintenance_bot removed a project: Patch-For-Review.Jun 19 2024, 9:30 AM
Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 22) board.Jun 19 2024, 11:47 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Jun 25 2024, 10:08 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Done on the Wikibase REST API (WPP) board.Jun 25 2024, 1:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits