Page MenuHomePhabricator

[[MediaWiki:Mwe-upwiz-blacklisted-details/en]] accessibility issue
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/UploadWizard/+/refs/heads/master/i18n/en.json#205

For accessibility, “click here” should never be a link text, because the link text should always describe the link. A more accessible version of this message would be:

This file name contains invalid characters or format. ([$2 Guidance on correcting the file name])

Rationale from the W3C: Many blind people who use screen readers call up a dialog box that has a list of links from the page. They use this list of links to decide where they will go. But if many of the links in that list simply say "click here" or "more" they will be unable to use this feature in their screen reader, which is a core navigation strategy. That's why it's a failure of 2.4.9 to not provide any way of allowing them to know the destination from the link text alone. It is also true for people who tab through links. If all they hear as they tab through the document is "click here, click here, click here etc." they will become confused.


Message URL: https://translatewiki.net/w/i.php?title=Special:Translate&showMessage=mwe-upwiz-blacklisted-details&group=ext-uploadwizard-user&language=ia

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Pppery updated the task description. (Show Details)

Hi! I’m a new contributor and I’d like to work on this task. It looks clear and beginner-friendly. Please let me know if it’s still available and if there’s anything specific I should keep in mind. Thanks!

Pppery subscribed.

It's still avaliable to work on. I don't have any particular suggestions, other than to say read https://www.mediawiki.org/wiki/New_Developers and https://www.mediawiki.org/wiki/Gerrit/Tutorial if you haven't already, good luck and thank you!

I've fixed the link to the codebase in the description, my apologies.

Hi! I’m a student contributor preparing for Google Summer of Code.

I plan to work on this task by updating the UploadWizard message to replace the non-descriptive “click here” link text with a more accessible, descriptive link label, while keeping the existing message structure and placeholders unchanged.

I’ll follow the guidance in the task description and accessibility best practices. Thanks!

Hi! I’ve submitted a patch addressing this task by replacing the non-descriptive “click here” link text with a more accessible, descriptive label, while keeping the existing placeholders intact.

Gerrit change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/1221107

Thanks!

Change #1221107 had a related patch set uploaded (by Pppery; author: Talhasajid849):

[mediawiki/extensions/UploadWizard@master] Improve accessibility of UploadWizard blacklist message

https://gerrit.wikimedia.org/r/1221107

Change #1221107 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Improve accessibility of UploadWizard blacklist message

https://gerrit.wikimedia.org/r/1221107

Welcome @Talhasajid849, and congrats on your first merged Gerrit patch!

Pppery claimed this task.
Pppery reassigned this task from Pppery to Talhasajid849.

Thanks a lot! 😊 Happy to have my first Gerrit patch merged. Looking forward to contributing more.

Change #1225006 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/UploadWizard@master] Reapply change accidentally reverted in security patch

https://gerrit.wikimedia.org/r/1225006

Change #1225006 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Reapply change accidentally reverted in security patch

https://gerrit.wikimedia.org/r/1225006