Page MenuHomePhabricator
Create Task
Maniphest T36852

Allow for <gallery> thumbnail links to be overridden and point to both internal and external links.
Closed, ResolvedPublic
Actions

Description

Author: kim

Description:
patch

I have created a patch which adds an optional parameter |link= to the <gallery> tag.

Here are a couple of examples.

<gallery>
File:20120106_001.jpg|link=[[DisplayLine]]
</gallery>

<gallery>
File:20120106_001.jpg|my caption|alt=my alt text|link=http://bugzilla.wikimedia.org
</gallery>

this would cause the link on the thumbnails rendered by the gallery tag to link to a custom page/url instead of the actual media/image.

The patch is fairly small, only touches two files. I would personally have commited these files to trunk, however i don't have core commit access, and i figured submitting it as a patch would carry less overhead.

Version: 1.20.x
Severity: enhancement

Attached:

gallery-thumbnail-link-override.patch211 KBDownload

Details

Reference
bz34852

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:15 AM
• bzimport added projects: MW-1.20.0-release, MediaWiki-Parser.
• bzimport set Reference to bz34852.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Mar 1 2012, 1:51 PM
• bzimport added a comment.Mar 2 2012, 2:06 AM

sumanah wrote:

Thanks for the patch, Kim! I made you a member of the group that can edit Bugzilla bugs, so if you have any future patches to core (between now and the Git migration) you can add the "patch" and "need-review" keywords to signal that your patch awaits inspection.

• bzimport added a comment.Mar 26 2012, 12:28 PM

kim wrote:

Would probably be better if this patch is implemented sooner rather than later, as it is sensitive to code change.

• bzimport added a comment.Apr 10 2012, 10:54 AM

kim wrote:

Added patch for code review.
https://gerrit.wikimedia.org/r/#change,4609

• brion added a comment.Apr 16 2012, 5:34 PM

Merged in https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=c9ebb1698c43c1df2da963958e6d1574383bf253

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL