Page MenuHomePhabricator

[ncmonitor] Detect, ignore, and notify about duplicate domain name entries in MarkMonitor
Open, In Progress, MediumPublic

Description

MarkMonitor can apparently have multiple domain configurations with the same domain name:

DEBUG:ncmonitor.markmonitor:Sending GET request to https://domains.markmonitor.com/domains/restapi/v2/domains/3293101
DEBUG:urllib3.connectionpool:https://domains.markmonitor.com:443 "GET /domains/restapi/v2/domains/3293101 HTTP/1.1" 200 486
DEBUG:ncmonitor.markmonitor:{[...], 'domainId': 3293101, 'domainName': 'wikimedia.ro', [...], 'status': 'closed, already registered', [...]}
DEBUG:ncmonitor.markmonitor:Sending GET request to https://domains.markmonitor.com/domains/restapi/v2/domains/3335690
DEBUG:urllib3.connectionpool:https://domains.markmonitor.com:443 "GET /domains/restapi/v2/domains/3335690 HTTP/1.1" 200 661
DEBUG:ncmonitor.markmonitor:{[...], 'domainId': 3335690, 'domainName': 'wikimedia.ro', [...], 'status': 'registered locked', [...]}

We need to ignore such situations and not include them in patches (the latter entry will overwrite the previous entry and can be erroneously included as validly set up, such as this case). Further, we should add this to the list of domains we nag about so that someone can fix it.

Details

TitleReferenceAuthorSource BranchDest Branch
Detect/notify about duplicate MarkMonitor domainsrepos/sre/ncmonitor!9brettT368758-mm-duplicate-domainsmain
Customize query in GitLab