Page MenuHomePhabricator

Add leading colon to parser-template-loop-warning
Closed, ResolvedPublic

Description

Per https://translatewiki.net/wiki/Support#Requesting_a_minor_change_to_the_MediaWiki:Parser-template-loop-warning_original_message:

Could we please change [[$1]] to [[:$1]]? A template loop on a file or category page does not display the message correctly without a colon.

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Change #1051337 had a related patch set uploaded (by Agamyasamuel; author: Agamyasamuel):

[mediawiki/core@master] Added leading colon to parser-template-loop-warning: https://phabricator.wikimedia.org/T368809 #368809 #T368809

https://gerrit.wikimedia.org/r/1051337

Change #1051337 had a related patch set uploaded (by Agamyasamuel; author: Agamyasamuel):

[mediawiki/core@master] Added leading colon to parser-template-loop-warning

https://gerrit.wikimedia.org/r/1051337

Pppery closed this task as Resolved.EditedWed, Jul 3, 9:04 PM
Pppery assigned this task to Agamyasamuel.

Note that this was done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051832, whose commit message was formatted in a way that didn't cause Gerritbot to see it. Someone should abandon https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051337 as a duplicate.

Congrats on your first merged Gerrit patch!

Change #1051337 abandoned by Agamyasamuel:

[mediawiki/core@master] Added leading colon to parser-template-loop-warning

Reason:

https://gerrit.wikimedia.org/r/1051337

Note that this was done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051832, whose commit message was formatted in a way that didn't cause Gerritbot to see it. Someone should abandon https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051337 as a duplicate.

Congrats on your first merged Gerrit patch!

Thanks, for the merge! As you have said, I have abondoned the Old commit https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1051337 [as duplicate]. As you mentioned, my newer commit was formated in the way, that Gerritbot didn't see it. can you lease tell me, what exactly was wrong in the commit message format, that casued this issue, I want to avoid this issue in future. -Thanks

"Bug:" needs to be immediately before "Change-Id:" in the commit message. See https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Phabricator

See also https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_(your_own_or_someone_else's) on how to amend changes within one patchset rather than uploading a new one for every subsequent change

"Bug:" needs to be immediately before "Change-Id:" in the commit message. See https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Phabricator

See also https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_(your_own_or_someone_else's) on how to amend changes within one patchset rather than uploading a new one for every subsequent change

Thanks for the Help!