Maniphest T369162

text/02-frontend-headers.vtc seems to be broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Vgutierrez
	Wed, Jul 3, 12:34 PM

Tags

Referenced Files

None

Subscribers

Description

While reviewing https://gerrit.wikimedia.org/r/c/operations/puppet/+/1030591/ I've noticed that GeoIP tests on text/02-frontend-headers.vtc seem to be broken:

$ grep ISP /tmp/vtcresults.XNPMl9fAB2 
**   s1    2.8 === expect req.http.X-GeoIP-ISP == "Century Link"
---- s1    2.8 EXPECT req.http.X-GeoIP-ISP (<undef>) == "Century Link" failed

it seems to me that tests are happy on production cause that expect stanza is never reached due to the wrong amount of requests/responses handled by server s1 on the test

Details

	Subject	Repo	Branch	Lines +/-
	varnish: Fix text/02-frontend-headers.vtc	operations/puppet	production	+19 -15

Customize query in gerrit

Event Timeline

Vgutierrez created this task.Wed, Jul 3, 12:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Jul 3, 12:34 PM

Vgutierrez triaged this task as Medium priority.Wed, Jul 3, 12:34 PM

Vgutierrez moved this task from Backlog to Traffic team actively servicing on the Traffic board.

Change #1051750 had a related patch set uploaded (by Vgutierrez; author: Vgutierrez):

[operations/puppet@production] varnish: Fix text/02-frontend-headers.vtc

https://gerrit.wikimedia.org/r/1051750

gerritbot added a project: Patch-For-Review.Wed, Jul 3, 12:40 PM

Change #1051750 merged by Vgutierrez:

[operations/puppet@production] varnish: Fix text/02-frontend-headers.vtc

https://gerrit.wikimedia.org/r/1051750

Vgutierrez closed this task as Resolved.Wed, Jul 3, 2:30 PM

Vgutierrez claimed this task.