Page MenuHomePhabricator
Create Task
Maniphest T371585

PHP 8.1 deprecation notice on every dewiki page with WikimediaEvents enabled
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue:

  • Setup a local wiki with the DB name dewiki in a multi-wiki setup
  • Visit any page on it

What happens?:

The following deprecation warning is emitted:

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/mediawiki/extensions/WikimediaEvents/includes/WikimediaEventsHooks.php on line 597

Details

SubjectRepoBranchLines +/-
Fix PHP 8.1 deprecation warning for null strpos() parammediawiki/extensions/WikimediaEventsmaster+1 -1
Customize query in gerrit

Event Timeline

mszabo created this task.Aug 1 2024, 9:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2024, 9:49 AM
mszabo changed the task status from Open to In Progress.Aug 1 2024, 9:49 AM
mszabo claimed this task.
mszabo triaged this task as Low priority.
mszabo moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.
gerritbot added a comment.Aug 1 2024, 9:50 AM

Change #1059023 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/extensions/WikimediaEvents@master] Fix PHP 8.1 deprecation warning for null strpos() param

https://gerrit.wikimedia.org/r/1059023

gerritbot added a project: Patch-For-Review.Aug 1 2024, 9:50 AM
gerritbot added a comment.Aug 1 2024, 10:44 AM

Change #1059023 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Fix PHP 8.1 deprecation warning for null strpos() param

https://gerrit.wikimedia.org/r/1059023

mszabo closed this task as Resolved.Aug 1 2024, 10:47 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 1 2024, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 1 2024, 11:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits