Page MenuHomePhabricator
Create Task
Maniphest T373981

Jump to the file before after pressing "remove image" in gallery edit window in visual editor
Open, Needs TriagePublicFeature
Actions

Description

current situation

  1. create a list of 10 files and feed it into gallery while using visual editor.
  2. now suppose you want to delete the 9th file. you press "remove image"
  3. it then jumps to the 1st file.

what should happen
jumps to the 8th file (the one before the removed target).

testing ground https://commons.wikimedia.org/w/index.php?title=Sandbox&oldid=919270949

Details

SubjectRepoBranchLines +/-
MWGalleryDialog: Highlight item at closest index when removing an imagemediawiki/extensions/VisualEditormaster+13 -4
Customize query in gerrit

Event Timeline

RoyZuo created this task.Sep 4 2024, 9:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2024, 9:15 AM
RoyZuo renamed this task from Jump to the file before after pressing "remove file" in gallery edit window in visual editor to Jump to the file before after pressing "remove image" in gallery edit window in visual editor.Sep 4 2024, 9:31 AM
RoyZuo updated the task description. (Show Details)
RoyZuo unsubscribed.
gerritbot added a comment.Sep 4 2024, 10:02 AM

Change #1070554 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] MWGalleryDialog: Highlight item at closest index when removing an image

https://gerrit.wikimedia.org/r/1070554

gerritbot added a project: Patch-For-Review.Sep 4 2024, 10:02 AM
PatchDemoBot added a comment.Sep 4 2024, 10:05 AM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/29bbc6fb2b/wiki/Gallery

gerritbot added a comment.Tue, Oct 29, 2:50 PM

Change #1070554 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWGalleryDialog: Highlight item at closest index when removing an image

https://gerrit.wikimedia.org/r/1070554

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Tue, Oct 29, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Tue, Oct 29, 3:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits