Page MenuHomePhabricator

Database table prefix missing from SQL query in SpecialDisambiguations.php
Closed, ResolvedPublic


Author: meowth346

In SpecialDisambiguations.php on about line 44, the line reads as:

. " FROM links as la, links as lb, cur as ca, cur as cb"

However, it should read to allow for database prefix as:

. " FROM $links as la, $links as lb, $cur as ca, $cur as cb"

Otherwise, the Special:Disambiguations page fails to locate the tables when they
have a prefix.

Version: 1.4.x
Severity: normal
OS: Linux
Platform: PC



Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:27 PM
bzimport set Reference to bz2008.

avarab wrote:

REL1_4_2 represents a specific point in time and has been frozen, so it won't be
fixed in that branch, this has however been fixed in CVS HEAD so the issue won't
be in any future branches.

zigger wrote:

Reopening to close as fixed. Tim fixed this in the REL1_4 branch as well as HEAD.

avarab wrote:

In response to Comment #3:

Marking it as WONTIX was the correct thing to do, the bug has *not* been fixed
in 1.4.2 and *never will*, simply because REL1_4_2 is a frozen branch which will
never get any future commits of any kind at any time in the future. The fact
that it has been fixed in REL1_4 and HEAD should be noted (which I did) but that
is irrelivant to the resolution of this bug which was reported against REL1_4_2.

Reopening to close as FIXED. Again.

The problem existed in the past, and has been fixed on the 1.4 release branch, and a
release has been made from that branch post the fix. Resolving as FIXED.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:24 AM