Page MenuHomePhabricator

request for update of languagebe.php file
Closed, ResolvedPublic

Description

Author: monk

Description:
file languagebe.php is updated (many items are translated now; all mentions of
wikipedia are out now).

see attach. tested on HEAD.


Version: 1.5.x
Severity: normal
OS: Windows XP
Platform: PC

Details

Reference
bz2135

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:27 PM
bzimport set Reference to bz2135.
bzimport added a subscriber: Unknown Object (MLST).

monk wrote:

new version of languagebe.php

attachment LanguageBe.php ignored as obsolete

avarab wrote:

Please:

  • Submit a patch to the current file
  • Use UNIX newlines rather than windows newlines (\n instead of \r\n)
  • Take out Wikipedia specific stuff like 'noarticletext' => "<div

style=\"border: 1px solid #ccc; padding: 7px;\">''', in the future we might
define a cute box for those warnings in CSS but the language files should not do
it on their own, this also goes for other hardcoded styles in your patch like
the one for sharedupload and nogomatch

  • Don't use the <charinsert> module in copyrightwarning, we don't ship it by

default and it shouldn't be used by default.

Thank you.

monk wrote:

patch for languagebe.php

patch; all recommendations of Ævar followed.

attachment patch for languagebe.php ignored as obsolete

monk wrote:

patch for languagebe.php (with a fix)

previous version lacked the important comma

Attached:

monk wrote:

patch for languagebe.php 1_4 branch

Patch for 1_4 branch (Revision 1.1.2.3)

Attached: