Page MenuHomePhabricator

Colliding duplicate use of 'w' and 'd' shortcut keys
Closed, ResolvedPublic

Assigned To
None
Authored By
bzimport
May 24 2005, 2:55 PM
Referenced Files
F2041: 2241d.patch
Nov 21 2014, 8:29 PM
F2040: 2241b.patch
Nov 21 2014, 8:29 PM
F2039: 2241a.patch
Nov 21 2014, 8:29 PM

Description

Author: puzzlet

Description:
Both general "Watch" link and "Watch this page" checkbox just under the edit box
have shortcut key alt+w.


Version: unspecified
Severity: minor

Details

Reference
bz2241

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:29 PM
bzimport set Reference to bz2241.

It would be great if there will be a solution in the near future :) I think,
alt-w should be kept for the "Watch"-link. alt-v seems to be available and to be
used for the checkbox.

Just another duplicate usage, but only for admins a problem: alt-d is used for
the delete-tab and "show changes" at the edit-modus.

ayg wrote:

Patch for 'w' conflict

This patch simply removes the watch/unwatch tab in edit mode. This is probably
desirable in any case, and so is normal behavior in non-Monobook-based skins
already: clicking the (un)watch button does nothing if you subsequently save
the submission form you have open, since it's silently overridden by the status
of the checkbox.

Attached:

ayg wrote:

Alternative 'w' patch

This is an alternative patch that just removes the accesskey from the
watch/unwatch tab during editing, rather than removing the tab altogether. So
if you press alt-W while editing, it just checks/unchecks the box.

Attached:

ayg wrote:

The 'd' collision was fixed eleven months ago in r10460. The shortcut for "show
changes" has been 'v' for almost a year.

ayg wrote:

Fix 'd' collision for remaining languages

(In reply to comment #5)

The 'd' collision was fixed eleven months ago in r10460. The shortcut for

"show

changes" has been 'v' for almost a year.

Correction: it was fixed for *some* languages. Cs, da, de, el, eu, it, ja, mk,
nn, pms, and sk are all still using 'd'.

attachment 2241c.patch ignored as obsolete

ayg wrote:

Fix 'd' collision for remaining languages (including ga)

Whoops, left out ga.

Attached:

ayg wrote:

'w' collision fixed in r16989 (per comment #3). 'd' collision remains.

Reverted r16989, as it made it more or less impossible to watch/unwatch a page that
doesn't presently exist without manually mucking about with URLs.

ayg wrote:

Both collisions fixed in r17118.

[[MediaWiki:tooltip-diff]] has to to changed too, at least for de:

jimmy.collins wrote:

(In reply to comment #11)

[[MediaWiki:tooltip-diff]] has to to changed too, at least for de:

Done in r17164.

epriestley added a commit: Unknown Object (Diffusion Commit).Mar 4 2015, 8:15 AM
epriestley added a commit: Unknown Object (Diffusion Commit).
epriestley added a commit: Unknown Object (Diffusion Commit).
epriestley added a commit: Unknown Object (Diffusion Commit).