Page MenuHomePhabricator

Links replacement run for each image caption
Closed, ResolvedPublic

Description

Author: jeluf

Description:
09:28 brion_: performance note in HEAD: it looks like the links replacement

set is being fully run for each image caption. this seems to
run a lot of duplicate make*LinkObj calls at the least (not 
sure about lookups)

Version: 1.5.x
Severity: normal

Details

Reference
bz2271

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:32 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz2271.
bzimport added a subscriber: Unknown Object (MLST).

Now uses replaceLinkHoldersText() which doesn't do the unnecessary lookups and just
inserts the text.