Page MenuHomePhabricator

MediaWiki:Edithelppage assumes internal url
Closed, ResolvedPublic


Author: conway

I was unable to use an external url (i.e. for MediaWiki:edithelppage as it
was always generating an internal url on pageview.

Here is a patch that fixes this.

Index: includes/EditPage.php

RCS file: /cvsroot/wikipedia/phase3/includes/EditPage.php,v
retrieving revision 1.176
diff -u -r1.176 EditPage.php

  • includes/EditPage.php 1 Jun 2005 08:18:34 -0000 1.176

+++ includes/EditPage.php 23 Jun 2005 20:43:50 -0000
@@ -520,7 +520,7 @@

$cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(),
                wfMsg('cancel') );
  • $edithelpurl = $sk->makeUrl( wfMsg( 'edithelppage' ));

+ $edithelpurl = $sk->makeInternalOrExternalUrl( wfMsg(
'edithelppage' ));

$edithelp = '<a target="helpwindow" href="'.$edithelpurl.'">'.
        htmlspecialchars( wfMsg( 'edithelp' ) ).'</a> '.
        htmlspecialchars( wfMsg( 'newwindow' ) );

Version: 1.5.x
Severity: normal
OS: Linux
Platform: PC



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:34 PM
bzimport set Reference to bz2496.
bzimport added a subscriber: Unknown Object (MLST).

Not sure what this means...? What's a case in which this fails, and what are the expected and
actual results?

conway wrote:

If I edit MediaWiki:edithelppage to be
"" instead of the default
"Help:Editing", and I go to edit a page, the url for the "Editing Help" link is
an internal one -

This patch lets either case work.

jeluf wrote:

Fixed in EditPage.php, rev 1.178