Page MenuHomePhabricator

Refactor EditPage::editForm
Closed, InvalidPublic

Description

Author: alanyst

Description:
The trunk version of EditPage::editForm is currently a roughly 500-line function
that builds the Edit page in all its various manifestations. Its large size and
number of variations (preview, diff, new article, edit conflict, etc.) make it
difficult to understand and improve. The function should be refactored so that
the bulk of its code is handed off to auxiliary functions, and what remains is
clear enough to follow the logic in building the edit form.


Version: 1.6.x
Severity: trivial

Details

Reference
bz3064

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:46 PM
bzimport set Reference to bz3064.
bzimport added a subscriber: Unknown Object (MLST).

alanyst wrote:

Factored out confirmDelete()

attachment bug3064.1.txt ignored as obsolete

alanyst wrote:

Comment on attachment 763
Factored out confirmDelete()

Attachment 763 has a bug. I will resubmit it.

alanyst wrote:

Factored out confirmDelete()

Corrected version of earlier patch 763.

Attached:

brion added a comment.Aug 23 2005, 6:37 PM

This function was recently refactored, so patch will probably not apply.