Page MenuHomePhabricator

Toolbar shows on non-existent pages
Closed, ResolvedPublic

Description

The toolbar still shows if the page does not exist.

This should only happen if the page is deleted after it's first added to their openTask cookie. S:GS has a length check (which implicitly includes checking that the page exists). Thus, this is worth fixing, but shouldn't be that common.


Version: master
Severity: normal

Details

Reference
bz50033

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz50033.
bzimport added a subscriber: Unknown Object (MLST).

swalling wrote:

(In reply to comment #0)

The toolbar still shows if the page does not exist.

This should only happen if the page is deleted after it's first added to
their
openTask cookie. S:GS has a length check (which implicitly includes checking
that the page exists). Thus, this is worth fixing, but shouldn't be that
common.

I tried to replicate this on piramido.wmflabs.org by deleting a page I had just been served correctly via Special:GettingStarted with the toolbar and then returning.

I still had the openTask cookie associated with that task/article, but the toolbar did not display on the redlink view (&action=edit&redlink=1). I did, however, get the guided tour.

(In reply to comment #1)

I still had the openTask cookie associated with that task/article, but the
toolbar did not display on the redlink view (&action=edit&redlink=1). I did,
however, get the guided tour.

I think that's because it's action=edit. If you visit directly (/wiki/Article), without action=edit, you should be able to reproduce.

swalling wrote:

(In reply to comment #2)

(In reply to comment #1)
> I still had the openTask cookie associated with that task/article, but the
> toolbar did not display on the redlink view (&action=edit&redlink=1). I did,
> however, get the guided tour.

I think that's because it's action=edit. If you visit directly
(/wiki/Article), without action=edit, you should be able to reproduce.

Bingo. Will attach screengrab for verification.

swalling wrote:

Toolbar on deleted page (Labs)

Attached:

Change 74822 had a related patch set uploaded by Mattflaschen:
Don't show toolbar if page does not exist.

https://gerrit.wikimedia.org/r/74822

Change 74822 merged by jenkins-bot:
Don't show toolbar if page does not exist.

https://gerrit.wikimedia.org/r/74822