Page MenuHomePhabricator

Inconsistent (double) textstring Special:Confirmemail and Special:Preferences
Closed, InvalidPublic

Description

In SpecialPreferences lines 287-289, currently text strings

  • mailerror, $1 and
  • eauthentsent, $1

are used; they have an additional $1 part. These parts are used, when a user
changes the stored e-mail address and the wiki automatically sends out the
confirmation e-mail.

In SpecialConfirmemail lines 55-57 a similar construct is used, when the user
explicitly requests e-mail confirmation. You can see the very similar code
construction. But they used strings are here

  • confirmemail_sendfailed and
  • confirmemail_sent

Due to a different program structure, wfMsg is not used here.

The target of this bugzilla is to show that an improved code (of text handling
in Confirmemail.php) could save two of the four text strings, becauses they have
essentially the same meaning.


Version: 1.5.x
Severity: trivial

Details

Reference
bz3293

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:49 PM
bzimport set Reference to bz3293.
bzimport added a subscriber: Unknown Object (MLST).