Page MenuHomePhabricator

Don't render diffs by default
Closed, ResolvedPublic

Assigned To
Authored By
Sep 12 2005, 3:36 PM
Referenced Files
F2302: diffonlypatch.txt
Nov 21 2014, 8:49 PM
F2301: nodiff
Nov 21 2014, 8:49 PM
F2300: diffonly.patch
Nov 21 2014, 8:49 PM


Author: mortgat

Many requests on the servers are done in order to watch changes (whether it is
vandalism or not).
When users check differences between versions, they don't necessarily want to
have the most recent version being displayed.
It would be a good enhancement if any logged user could choose: displaying the
changed version or not?

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:49 PM
bzimport set Reference to bz3446.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

I thought that the History page allows you to choose whichever diff you wish to
see? The reason for the most recent change being shown under something like
Recent Changes is because, logically, that is what the user expects to see.
Could you explain further if I've misunderstood?

mortgat wrote:

I think there is a misunderstanding!
When you compare two versions of an article, you can see what's changed between
both articles seeing their code and you see also the rendering corresponding
with the last code.
That's true when you click "diff" in the RC, and when you compare two versions
of an article via the History.

I'd like to disable the rendering in my individual preferences, since the
servers are overwhelmed with such requests only to check the nature of recent

Nice day

Benoit Mortgat

robchur wrote:

Oh, I see. Yes, I'd agree with that logic.

dake.cdx wrote:

This would be very useful indeed. You don't need to see the whole page to track
down vandalism and such.

Siegel wrote:

I agree this would be useful. see bug #3365 and

lupin.wp wrote:

patch without user pref

This patch adds the diffonly flag which suppresses the article display if


ezyang wrote:

*** Bug 3365 has been marked as a duplicate of this bug. ***

ezyang wrote:

Bug 208 may be related (the external API), but I don't think they have anything
to do with each other. Lupin, would you be able to extend user preferences to
make diffonly apply globally?

lupin.wp wrote:

add user pref

There's an option in Special:Preferences with this patch, under "Misc". You can
override that setting using diffonly=0 or diffonly=1 in the url.

attachment nodiff ignored as obsolete

lupin.wp wrote:

patch with user pref

Oops, forgot Messages.php - apologies.


I'm leery of adding preference options; they complicate things.

francesco.cosoleto wrote:

patch with user pref and "show diff with article" link

I added a "Show diff with article" link in diff generated page with diffonly
flag enabled. Pref or not pref, I think "diffonly" it's fine feature.


angus wrote:

*** Bug 8488 has been marked as a duplicate of this bug. ***

ayg wrote:

*** Bug 6936 has been marked as a duplicate of this bug. ***

Fixed in r19141 based on a combination of Francesco's patch with a similar
change I'd written myself.

So how does it work? How can this be implemented into our regular wiki usage?

rotemliss wrote:

(In reply to comment #16)

So how does it work? How can this be implemented into our regular wiki usage?

This the the commit description:

(bug 3446) Add user preference to hide page content below diffs, can be
overridden by adding diffonly=1 or diffonly=0 to the URL of the diff page

I think it's clear enough.

francesco.cosoleto wrote:

Thank you. (Not "Francesco's patch", but Lupin)