Page MenuHomePhabricator

500 error when canceling Google OAuth authentication
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Click on Connect with Google
  2. Click on cancel when Google asks permission for account details.
  3. 500 Error

Expected Behavior

After canceling authorizatin return to login screen of Wikimetrics

Stacktrace

[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] mod_wsgi (pid=27887): Exception occurred processing WSGI script '/usr/lib/wikimetrics/wikimetrics/api.wsgi'.
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] Traceback (most recent call last):
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1701, in call
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] return self.wsgi_app(environ, start_response)
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1689, in wsgi_app
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] response = self.make_response(self.handle_exception(e))
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1687, in wsgi_app
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] response = self.full_dispatch_request()
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1360, in full_dispatch_request
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] rv = self.handle_user_exception(e)
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1358, in full_dispatch_request
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] rv = self.dispatch_request()
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1344, in dispatch_request
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] return self.view_functions[rule.endpoint](req.view_args)
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/local/lib/python2.7/dist-packages/flask_oauth.py", line 433, in decorated
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] return f(*((data,) + args),
kwargs)
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] File "/usr/lib/wikimetrics/wikimetrics/controllers/authentication.py", line 104, in auth_google
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] access_token = resp['access_token'] or request.args.get('code')
[Mon Aug 12 13:09:49 2013] [error] [client 203.184.139.14] TypeError: 'NoneType' object has no attribute 'getitem'


Version: unspecified
Severity: normal
See Also:
https://mingle.corp.wikimedia.org/projects/analytics/cards/1069

Details

Reference
bz52749