Page MenuHomePhabricator

Add a hook to Revision
Closed, DeclinedPublic

Description

We are working on the Semantic MediaWiki extension (see
http://meta.wikimedia.org/wiki/Semantic_MediaWiki ). In order to create an easy
to install extension and not to need to patch the MediaWiki first, we would ask
to add the following hook at the end of the function getRevisionText in the
Revision class in Revision.php:

wfRunHooks('RevisionAfterGetRevisionText', array(&$text));

The patch is based on the 1.5rc4 from SourceForge.


Version: 1.5.x
Severity: enhancement

Details

Reference
bz3577

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 8:52 PM
bzimport set Reference to bz3577.
bzimport added a subscriber: Unknown Object (MLST).

patch with suggested hook, based on mw 1.5rc4

attachment revextrahook ignored as obsolete

diff -u used, patch to resolve enhancement

Attached:

avarab wrote:

FIXED in HEAD and REL1_5

I'm reverting this until someone explains what it's intended to do.

Note that modifying text in that part of the code would cause data corruption when
things are moved from one storage mode to another. If you want a hook that filters data
on wiki rendering, that needs to be somewhere else.

No further information from requester, resolving WONTFIX.

Diffusion changed the task status from Declined to Resolved by committing Unknown Object (Diffusion Commit).Mar 4 2015, 8:15 AM
Diffusion added a commit: Unknown Object (Diffusion Commit).
Diffusion added a commit: Unknown Object (Diffusion Commit).
Diffusion added a commit: Unknown Object (Diffusion Commit).
Diffusion added a commit: Unknown Object (Diffusion Commit).
Aklapper changed the task status from Resolved to Declined.Mar 4 2015, 5:47 PM
Aklapper claimed this task.