Page MenuHomePhabricator

Premature instantiation of User object
Closed, ResolvedPublic

Description

Author: robchur

Description:
Line 74 of User.php in version 1.5 allocates a relatively heavy User object
before it is needed; during the period between allocation and use, several
possibilities for leaving the function are available.

Proposed to move the instantiation to just above it's use.


Version: 1.5.x
Severity: normal

Details

Reference
bz3642

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:50 PM
bzimport set Reference to bz3642.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Patch for version 1.5

Patch to fix the problem as I proposed above.

Attached:

Seems to have already been done on HEAD.