Page MenuHomePhabricator

Missing string in function getFullURL in Title.php
Closed, ResolvedPublic

Description

Author: ohoo

Description:
Using last MediaWiki 1.5.0 - 2005-10-05 release

In includes/Title.php there is a function called "getFullURL":
function getFullURL( $query = '') {

So, at line 658 there is a row:

		if ( '' == $this->mInterwiki ) {

but it should be:

		if ( $query == $this->mInterwiki ) {

and at line 668 there is a row:

		if ( '' != $namespace ) {

but it should be:

		if ( $query != $namespace ) {

and at line 681 there is a row:

		if ( '' != $this->mFragment ) {

but it should be:

		if ( $query != $this->mFragment ) {

Otherwise getFullURL are not working (eg. Search field "Go" are not working when
$wgGoToEdit = true), after correcting those lines, everything is now OK!


Version: 1.5.x
Severity: normal
OS: Linux
Platform: PC

Details

Reference
bz3743

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:52 PM
bzimport added a project: MediaWiki-Search.
bzimport set Reference to bz3743.
bzimport added a subscriber: Unknown Object (MLST).

gangleri wrote:

*** This bug has been marked as a duplicate of 3742 ***