Page MenuHomePhabricator

Respect x-forwarded-for header in Wikimania Scholarships application
Closed, DeclinedPublic

Description

The application attempts to capture the submitting user's ip address to associate with their scholarship request. The current application logic captures $_SERVER['REMOTE_ADDR'] which will be mostly useless in production as the application will be proxied via an SSL terminator proxy and Varnish.


Version: wmf-deployment
Severity: normal

Details

Reference
bz58069

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:23 AM
bzimport set Reference to bz58069.

It wouldn't be a horrible idea to make sure that the application will properly store IPv6 addresses in the database at the same time this issue is addressed.

Change 100440 had a related patch set uploaded by BryanDavis:
Respect X-Forwarded-For header when present

https://gerrit.wikimedia.org/r/100440

Change 100440 abandoned by BryanDavis:
Respect X-Forwarded-For header when present

Reason:
Not needed due to Bug 58295.

https://gerrit.wikimedia.org/r/100440

Remote IP will no longer be stored due to Bug 58295