Page MenuHomePhabricator

JS error on shop's main page (unclosed <script>)
Closed, ResolvedPublic

Description

JS error on shop's main page (unclosed <script>)

I don't remember quite how the shop normally looks but seems different (e.g. styles missing?) and confirmed behavior/error in console in both iceweasel/chromium.

There's a series of many script elements one of which is unclosed. The next script element is then interpreted as JS. It's an exception which then halts processing the rest of the script elements on the page.

excerpt from current markup (the unclosed <script> is first):

<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','//www.google-analytics.com/analytics.js','ga');

ga('create', 'UA-45430427-1', 'wikimedia.org');
ga('send', 'pageview');

<script type="text/javascript" src="//assets.zendesk.com/external/zenbox/v2.6/zenbox.js"></script>


Version: wmf-deployment
Severity: blocker
URL: https://shop.wikimedia.org/

Details

Reference
bz61527

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:04 AM
bzimport added a project: Wikimedia-Shop.
bzimport set Reference to bz61527.

Thanks for the extra detail, Jeremyb. I'm trying to figure out how this happened and will update once I have more information.

  • Bug 61530 has been marked as a duplicate of this bug. ***

(In reply to Caitlin Cogdill from comment #1)

Thanks for the extra detail, Jeremyb. I'm trying to figure out how this
happened and will update once I have more information.

Apparently the shop has an off switch. It now auto-redirects to /password and reads (in a pretty wrapper):


The Wikimedia Shop is currently down due to technical difficulties. We hope to be back online shortly! Thank you for your patience.

Nice feature. :-)

Indeed! We thought it would be best to take it down until we know how this happened.

Caitlin: do you have any thoughts regarding when to remove the "Wikimedia Shop" link from the English Wikipedia sidebar? If the shop site is going to be down for more than a day or two, we should consider temporarily removing the link. Though, of course, caching will really hamper any efforts.

(In reply to MZMcBride from comment #5)

I just noticed that https://shop.wikimedia.org/password now reads:


The Wikimedia Shop will be down through Tuesday, Feb 25. This date may extend if further maintenance is required. We apologize for the inconvenience and appreciate your patience with this matter.

A bit of a "damned if you do, damned if you don't" situation regarding the sidebar link. Hrm.

Caitlin: Looks like http://shop.wikimedia.org/ is back?
Can this ticket be closed?

Yes, this has been solved. We were able to work with tech and determine that a WMF stylesheets had been moved and, not realizing it was in use for the shop, we weren't notified. The store went live once more on 2/20 at 12:13pm PST.

The good news is this occasion has opened up a discussion to get tech a little more involved with the shop, which should help prevent issues like this from recurring and hopefully help accomplish some of our other future goals.

Thanks again, everyone, for helping diagnose the problem.