Page MenuHomePhabricator

Add "assign to ___" to Tasks forms
Closed, ResolvedPublic

Description

Author: philharnish

Description:
This patch will add two new text boxes which allow a task to be assigned to a
specific username.
The first box appears under the "Comments" field and allows a new task to be
assigned to someone.
The second box appears in the "Assignment/Actions/Page" column for a task if not
already assigned.

This required adding one additional string to en.php which contains "Assign to".
I have attempted a French translation ("Assignée Ã") using other text and what
little I remember from high school.


Version: unspecified
Severity: enhancement

Details

Reference
bz4617

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:02 PM
bzimport set Reference to bz4617.
bzimport added a subscriber: Unknown Object (MLST).

philharnish wrote:

Patches Tasks extension

This patches the HEAD version of Tasks.php, en.php, and fr.php

attachment tasks_patch_060114.txt ignored as obsolete

philharnish wrote:

Apply patch to HEAD of Tasks extension, take 2

Changes suggested by Ævar Arnfjörð Bjarmason

  • Encode ?title= value to prevent injection (real big mistake, sorry)
  • Handle usernames which may be '0' or other flavors of "empty"
  • Removed French translation of "Assign to"
  • Removed commented line which could print "Assigned to no one"

attachment tasks_patch_060115.txt ignored as obsolete

philharnish wrote:

cc: magnus_manske

avarab wrote:

Fails to apply to current CVS HEAD, also looks like you're using Windows
newlines which mess up the patch

philharnish wrote:

Apply patch to HEAD of Tasks extension, take 3

Editor removed trailing whitespace so it was not able to match surrounding
text. This even happened when I tested the patch. It should work this time.
Sorry for the trouble.

Reproduced modifications from scratch (with trailing space maintained),
regenerated patch, tested patch against HEAD, tested patched file in wiki.

Attached:

robchur wrote:

Closing, since Phil says this has been committed.